Dashboard flex fix

?

The padding-margins are hectic, the first row is fine, it has the same padding on both sides.
The second row is most likely left oriented, on the left side there is no margin, on the right there is a small one.

I bet flex is different for them, haven't checked yet though.

Isn't this just the way flex wraps content? Apart from in a few places (like the top row that is static across all pages), we're not explicitly forcing a new row since a lot of the content is dynamic, instead letting flex wrap when it needs to.

Well, I mean I guess it depends how we use flex? Not sure about the wrapping, but I think  if the container itself has a starting and ending point set, then at least the paddings on the very ends could be the same as say the first fixed row.

Not "fluent" in flex so maybe I'm talking crazy
I usually use this cheat sheet 

https://css-tricks.com/snippets/css/a-guide-to-flexbox/

keep this one open and we get back to it, just in case

I was giving it another thought, I can think of something.
So now the way we handle flex in ceo page at least is that we have 
a normal contentwrapper
inside that we have our normal rows, all flex containers themselves
while the bottom buttons row and the footer is outside of the contantwrapper
buttons row is flexed, footer is not.


I'd rehaul the whole things tbh.

I imagine it this way:
From the root of the body every content I'd put in a flex container (so the main container would be flexed),
then rewrite all the rows to be flex themselves and align to the container.

That way we'd have not only more flexibility, but the space between and around all and everything would be consistent without giving it a further thought ever.

What do you think?

From this I just found a couple of other bits of broken HTML that were messing up the layout more on the CEO page, and also one affecting every page.

DOM structure should (currently) be maincontainer -> contentwrapper -> main_content -> all the page content. 

I'm not sure if that fixes the issues you're noticing?

I agree we need to straighten out a standard, even if its only on the code side of things. There seem to be a few duplicate functions for generating UI elements, and I don't remember why and seem to use them somewhat interchangeably, which is... not good lol

I think if I'm getting you right, your idea would be to add flex stuff to main_content, so all the 'row ui-canvas' div rows would be flexed inside the overall page?

Yes, so the main_content would be the parent flex, and everything else would be child flex (they could be parents on their own too, we can nest them as many times as we need it)

This will possibly mess up the css at some places at first, but would be easier to manage on the long run.
Also, -theoretically- finally it would behave exavtly the same regardless of the browser. (though other than that ff bug it works pretty much the same everywhere I tried, like edge, or other chromium)

Hmm, adding flex to main_content seriously fucked up the layout entirely

On 2/22/2022 at 7:20 AM, Darkmyre said:

Hmm, adding flex to main_content seriously fucked up the layout entirely

I was afraid so, I mean a lot of variables on that level but it can be fixed, have you tried it on the beta?
Coz I can't see it now!?